Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cached task instances (2) #425

Merged
merged 3 commits into from
May 27, 2024
Merged

Cached task instances (2) #425

merged 3 commits into from
May 27, 2024

Conversation

klieret
Copy link
Member

@klieret klieret commented May 27, 2024

Follow up to #317

  • Add test for caching of task envs
  • Make cached image name depend only on relevant features

@klieret klieret changed the title cached task images enh Cached task instances (2) May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 76.06%. Comparing base (2a0c164) to head (98def92).
Report is 1 commits behind head on main.

Current head 98def92 differs from pull request most recent head 5b4f181

Please upload reports for the commit 5b4f181 to get more accurate results.

Files Patch % Lines
tests/test_env.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
+ Coverage   75.09%   76.06%   +0.97%     
==========================================
  Files          18       18              
  Lines        2951     2975      +24     
==========================================
+ Hits         2216     2263      +47     
+ Misses        735      712      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klieret klieret merged commit 3582b35 into main May 27, 2024
5 checks passed
@klieret klieret deleted the cached-task-images-enh branch May 27, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant